Skip to content

Fix input focus flow in profile dialog - #119

Merged
ProdigyV21 merged 1 commit into
ProdigyV21:mainfrom
Himanth-reddy:fix/profile-dialog-focus
Apr 5, 2026
Merged

Fix input focus flow in profile dialog#119
ProdigyV21 merged 1 commit into
ProdigyV21:mainfrom
Himanth-reddy:fix/profile-dialog-focus

Conversation

@Himanth-reddy

Copy link
Copy Markdown
Collaborator

This pull request enhances the user experience of the profile dialogs by improving keyboard handling and focus management, especially when interacting with text inputs and dialog buttons. The main focus is on ensuring that the soft keyboard is shown or hidden at appropriate times, auto-focusing the name input when adding a profile, and providing consistent behavior across touch and non-touch devices.

Keyboard and Focus Management Improvements:

  • Introduced showKeyboard and hideKeyboard helper functions to control the soft keyboard visibility more reliably when focusing or dismissing the name input field. These functions are now used throughout the dialog for better consistency. [1] [2] [3] [4]
  • Updated the logic so that the keyboard is automatically shown and the name input is focused when adding a new profile (autoFocusNameInput = true), but not when editing an existing profile. [1] [2] [3]
  • Improved the handling of the "Done" action and Enter key in the name input: the keyboard is now hidden and focus is moved to the confirm button when either is pressed, improving usability on both touch and non-touch devices.

Dialog Button Behavior:

  • Ensured that the keyboard is hidden before executing any dialog button action (Confirm, Cancel, Delete), preventing the keyboard from lingering after the dialog is dismissed or an action is taken. [1] [2]

Other UI/UX Enhancements:

  • Added .focusable() modifier to dialog buttons on touch devices to improve accessibility and focus handling.
  • Minor import addition for KeyEvent to support improved keyboard handling.

@ProdigyV21
ProdigyV21 merged commit 155d7f5 into ProdigyV21:main Apr 5, 2026
2 checks passed
@Himanth-reddy
Himanth-reddy deleted the fix/profile-dialog-focus branch April 12, 2026 17:18
@Himanth-reddy Himanth-reddy added gssoc-approved level:beginner Beginner level task quality:clean Clean code implementation type:bug Bug fix type:design UI/UX design enhancements gssoc:approved GSSoC approved contribution and removed gssoc:approved labels Jul 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gssoc:approved GSSoC approved contribution level:beginner Beginner level task quality:clean Clean code implementation type:bug Bug fix type:design UI/UX design enhancements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants